[SPARK-46598][SQL] OrcColumnarBatchReader should respect the memory mode when creating column vectors for the missing column #44598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
changed the title
Contributor
Author
LuciferYang
approved these changes
Jan 4, 2024
Contributor
There was a problem hiding this comment.
Is it possible to use ConstantColumnVector for the missingCol? This maybe another story.
Contributor
Author
There was a problem hiding this comment.
It seems simpler to use ConstantColumnVector here. I've updated the PR
LuciferYang
reviewed
Jan 4, 2024
Contributor
There was a problem hiding this comment.
[info] - SPARK-28156: self-join should not miss cached view *** FAILED *** (216 milliseconds)
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 1 in stage 1888.0 failed 1 times, most recent failure: Lost task 1.0 in stage 1888.0 (TID 2251) (localhost executor driver): java.lang.NullPointerException: Cannot invoke "org.apache.spark.internal.config.ConfigReader.get(String)" because "reader" is null
[info] at org.apache.spark.internal.config.ConfigEntry.readString(ConfigEntry.scala:94)
[info] at org.apache.spark.internal.config.FallbackConfigEntry.readFrom(ConfigEntry.scala:270)
[info] at org.apache.spark.sql.internal.SQLConf.getConf(SQLConf.scala:5573)
[info] at org.apache.spark.sql.internal.SQLConf.offHeapColumnVectorEnabled(SQLConf.scala:5103)
[info] at org.apache.spark.sql.execution.datasources.orc.OrcFileFormat.$anonfun$buildReaderWithPartitionValues$2(OrcFileFormat.scala:200)
[info] at org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.org$apache$spark$sql$execution$datasources$FileScanRDD$$anon$$readCurrentFile(FileScanRDD.scala:218)
some tests failed
viirya
approved these changes
Jan 4, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @cloud-fan . Could you fix the test failures?
cloud-fan
changed the title
yaooqinn
approved these changes
Jan 5, 2024
dongjoon-hyun
approved these changes
Jan 5, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. This looks much nicer. Thanks!
Contributor
Seems if using |
…olumn vectors for the missing column
cloud-fan
changed the title
Contributor
Author
|
I changed it back. It seems non-trivial to make |
cloud-fan
commented
Jan 5, 2024
| assert(supportBatch(sparkSession, resultSchema)) | ||
| } | ||
|
|
||
| val memoryMode = if (sqlConf.offHeapColumnVectorEnabled) { |
Contributor
Author
There was a problem hiding this comment.
I moved it outside of the lambda, so that we don't hit NPE by referencing sqlConf.
dongjoon-hyun
approved these changes
Jan 5, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you re-trigger the failed pipelines?
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 6, 2024
…ode when creating column vectors for the missing column This PR fixes a long-standing bug that `OrcColumnarBatchReader` does not respect the memory mode when creating column vectors for missing columbs. This PR fixes it. To not violate the memory mode requirement No new test no Closes #44598 from cloud-fan/orc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 0c1c5e9) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 6, 2024
…ode when creating column vectors for the missing column This PR fixes a long-standing bug that `OrcColumnarBatchReader` does not respect the memory mode when creating column vectors for missing columbs. This PR fixes it. To not violate the memory mode requirement No new test no Closes #44598 from cloud-fan/orc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 0c1c5e9) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
Thank you, @cloud-fan and all. |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…ode when creating column vectors for the missing column This PR fixes a long-standing bug that `OrcColumnarBatchReader` does not respect the memory mode when creating column vectors for missing columbs. This PR fixes it. To not violate the memory mode requirement No new test no Closes apache#44598 from cloud-fan/orc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 0c1c5e9) Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 53683a8) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a long-standing bug that
OrcColumnarBatchReaderdoes not respect the memory mode when creating column vectors for missing columbs. This PR fixes it.Why are the changes needed?
To not violate the memory mode requirement
Does this PR introduce any user-facing change?
No
How was this patch tested?
new test
Was this patch authored or co-authored using generative AI tooling?
no